Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Reduce reviewers scope #316

Merged
merged 1 commit into from
Sep 25, 2024
Merged

ci: Reduce reviewers scope #316

merged 1 commit into from
Sep 25, 2024

Conversation

jesse-c
Copy link
Contributor

@jesse-c jesse-c commented Aug 27, 2024

Description

Same as climatepolicyradar/navigator-frontend#200.

Proposed version

Please select the option below that is most relevant from the list below. This
will be used to generate the next tag version name during auto-tagging.

  • Skip auto-tagging
  • Patch
  • Minor version
  • Major version

Visit the Semver website to understand the
difference between MAJOR, MINOR, and PATCH versions.

Notes:

  • If none of these options are selected, auto-tagging will fail
  • Where multiple options are selected, the most senior option ticked will be
    used -- e.g. Major > Minor > Patch
  • If you are selecting the version in the list above using the textbox, make
    sure your selected option is marked [x] with no spaces in between the
    brackets and the x

Type of change

Please select the option(s) below that are most relevant:

  • Bug fix
  • New feature
  • Breaking change
  • GitHub workflow update
  • Documentation update
  • Refactor legacy code
  • Dependency update

How Has This Been Tested?

N/A

Reviewer Checklist

  • The PR represents a single feature (small driveby fixes are also ok)
  • The PR includes tests that are sufficient for the level of risk
  • The code is sufficiently commented, particularly in hard-to-understand areas
  • Any required documentation updates have been made
  • Any TODOs added are captured in future tickets
  • No FIXMEs remain

@jesse-c jesse-c requested a review from a team as a code owner August 27, 2024 16:21
.github/CODEOWNERS Outdated Show resolved Hide resolved
@jesse-c jesse-c force-pushed the reduce-reviewers-scope branch from 83238af to 473e38c Compare September 25, 2024 08:53
.github/CODEOWNERS Outdated Show resolved Hide resolved
Copy link
Contributor

@katybaulch katybaulch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one - please add deng as a required reviewer for the search schema file though please (chances of us breaking that at some point feel quite high) :)

@jesse-c jesse-c force-pushed the reduce-reviewers-scope branch 2 times, most recently from 4d3e2ef to 89a6db5 Compare September 25, 2024 10:52
.github/CODEOWNERS Outdated Show resolved Hide resolved
@jesse-c jesse-c force-pushed the reduce-reviewers-scope branch from 89a6db5 to a799b40 Compare September 25, 2024 12:39
@jesse-c jesse-c merged commit f44f60a into main Sep 25, 2024
12 checks passed
@jesse-c jesse-c deleted the reduce-reviewers-scope branch September 25, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants